fix(helper-globals): Update browser-upper.json - #17981
Merged
nicolo-ribaudo merged 4 commits intoMay 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
See sindresorhus/unicorn-magic@1d55418 We bundle npm-run-path/unicorn-magic for the makefile.js.
Copy link
Copy Markdown
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61485 |
Sorry, something went wrong.
JLHwung
marked this pull request as ready for review
May 6, 2026 13:51
liuxingbaoyu
approved these changes
May 6, 2026
nicolo-ribaudo
approved these changes
May 6, 2026
Copy link
Copy Markdown
Member
|
Merging this PR for now so that it doesn't get conflicts due to the yarn.lock changes, but could the npm-run-path thing be solved by setting the node condition when bundling our makefile? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
I guess we could, I will try to open a new PR get rid of the patches. |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we remove the yarn.lock and re-run yarn, essentially bumping all deps to the latest version according to the current version spec.
We also patched npm-run-path as we bundle we bundle npm-run-path -> unicorn-magic for the makefile.js.
I will mark this PR as ready when the CI is green.