Use md4 instead of sha1 for filename hashes - #638
Merged
xtuc merged 1 commit intoJul 5, 2018
Merged
xtuc merged 1 commit into
xtuc merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
We don't need the cryptographic strength of SHA-1 for this purpose, so we may as well use a faster hashing algorithm. While I was at it, I also sapped out the use of hash.end + hash.read combo for the faster and more conventional hash.update + hash.digest. In my local testing, this also seems to offer a nice speed boost.
xtuc
approved these changes
Jul 5, 2018
xtuc
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks. Webpack did that too
Sorry, something went wrong.
existentialism
approved these changes
Jul 5, 2018
Copy link
Copy Markdown
Member
|
We should land this change in master too? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Yes that's a good idea. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
And we can release this as a patch? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Jul 6, 2018
Merged
This was referenced Mar 17, 2020
This was referenced May 29, 2021
1 task
This was referenced Jun 6, 2021
Closed
Closed
This was referenced Jun 16, 2021
Closed
1 task
1 task
This was referenced Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need the cryptographic strength of SHA-1 for this purpose, so
we may as well use a faster hashing algorithm.
While I was at it, I also sapped out the use of hash.end + hash.read
combo for the faster and more conventional hash.update + hash.digest. In
my local testing, this also seems to offer a nice speed boost.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Uses SHA-1 for cache filename hash.
What is the new behavior?
Uses MD4 for cache filename hash.
Does this PR introduce a breaking change?
Other information:
I wrote this PR against the 7.x branch in hopes that we could get it into a 7.x release. If you think this is a good approach, I am happy to open a similar PR against master.