Feature/read only analog value present value - #1424
Merged
skarg merged 8 commits intoJul 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
- Move Analog Value object structure into the C module and add get/set for the members. - Added functions to get and set `Min_Pres_Value` and `Max_Pres_Value` properties. - Implemented write enable/disable functionality for the Analog Value object. - Enhanced the test suite to cover new property APIs and validate their functionality.
- update float initializations to use 'f' suffix for consistency - remove write-enabled for present-value coupling to out-of-service flag.
…ionally skip Present_Value and allow writing when out-of-service is TRUE.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several BACnet object implementations to better control Present_Value writability (including Out_Of_Service behavior) and expands Analog Value capabilities with min/max present value support and additional direct-API tests.
Changes:
- Add/adjust “write-enabled” + Out_Of_Service-driven Present_Value write behavior across multiple object types.
- Extend Analog Value with Min/Max Present Value properties and new exported helper APIs; add unit tests for the direct APIs.
- Normalize some float literals/range comparisons (e.g., 1.414f, isgreaterequal/islessequal, FLT_MAX defaults).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 11 comments.
Show a summary per file| File | Description |
|---|---|
| test/bacnet/basic/object/av/src/main.c | Adds direct Analog Value API tests and required C library includes. |
| src/bacnet/basic/object/time_value.c | Updates writable property list behavior and Out_Of_Service / Present_Value write logic. |
| src/bacnet/basic/object/msv.c | Updates writable property list behavior and Present_Value write permissions. |
| src/bacnet/basic/object/ms-input.c | Updates writable property list behavior and Present_Value write permissions; shifts some lookups to Multistate_Input_Object(). |
| src/bacnet/basic/object/bv.c | Updates writable property list behavior, Present_Value write permissions, and default Write_Enabled. |
| src/bacnet/basic/object/bitstring_value.c | Updates writable property list behavior. |
| src/bacnet/basic/object/bi.c | Updates writable property list behavior and Present_Value write permissions. |
| src/bacnet/basic/object/av.h | Removes the public ANALOG_VALUE_DESCR typedef and exports new AV APIs (min/max, write enable). |
| src/bacnet/basic/object/av.c | Introduces new AV object_data struct, min/max properties, and updated Present_Value write handling. |
| src/bacnet/basic/object/ao.c | Tightens float literal suffixes and uses isgreaterequal/islessequal for range checks; updates defaults. |
| src/bacnet/basic/object/ai.c | Expands Writable_Properties list and normalizes float suffixes in a few places. |
Sorry, something went wrong.
Comment thread
src/bacnet/basic/object/av.c
Outdated
Comment thread
src/bacnet/basic/object/time_value.c
Outdated
Comment thread
src/bacnet/basic/object/av.c
Outdated
Comment thread
src/bacnet/basic/object/bv.c
Outdated
Comment thread
src/bacnet/basic/object/bi.c
Outdated
Comment thread
src/bacnet/basic/object/ms-input.c
Outdated
Comment thread
src/bacnet/basic/object/bitstring_value.c
Outdated
Comment thread
src/bacnet/basic/object/time_value.c
Outdated
Comment thread
src/bacnet/basic/object/msv.c
Comment thread
src/bacnet/basic/object/ms-input.c
…always set properties to a list. fix: analog value write present value logic for enabled and out-of-service.
… for read-only objects
ryanjmulder
pushed a commit
to AntrumIAQ/bacnet-stack
that referenced
this pull request
Jul 16, 2026
* feat: analog value min/max and read-only options. - Move Analog Value object structure into the C module and add get/set for the members. - Add `Min_Pres_Value` and `Max_Pres_Value` properties to Analog Value object - Implement write enable/disable functionality for the Analog Value object. - Enhance the test suite to cover new property APIs and validate their functionality. - Update float initialization to use 'f' suffix for consistency in analog objects - Remove write-enabled for present-value coupling to out-of-service flag in value objects - Change writable properties for value objects to conditionally skip Present_Value and allow writing when out-of-service is TRUE. - Enable write by default for value objects that support the Write_Enable flag. - Add writable property list tests for various BACnet object types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.