pipe一些修改 - #4
Open
pengsven wants to merge 17 commits into
Open
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
liu-s-yuan
force-pushed
the
siyuan.make_ngx_resp
branch
from
6fe6055 to
ad90694
Compare
November 22, 2017 11:30
drmingdrmer
approved these changes
Nov 23, 2017
drmingdrmer
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
nice
Sorry, something went wrong.
lishulong
approved these changes
Nov 23, 2017
Comment thread
lib/pipe/httplib.lua
|
|
||
| if opts.signature_cb ~= nil then | ||
| req = opts.signature_cb(req) | ||
| end |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
上面这些初始化和赋值是不是可以从for循环中拿出去
Sorry, something went wrong.
Comment thread
lib/pipe/httplib.lua
| end | ||
| end | ||
|
|
||
| if err_code ~= nil then |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
这里可以直接返回错误
Sorry, something went wrong.
Comment thread
lib/pipe/reader.lua
Outdated
| break | ||
| end | ||
| end | ||
| function _M.loop_http_read(pobj, ident, http) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
上面那几个函数还需要在这里保留吗？
Sorry, something went wrong.
Comment thread
lib/pipe/writer.lua
| end | ||
| function _M.connect_http(ips, port, verb, uri, opts) | ||
| return httplib.connect_http(ips, port, verb, uri, opts) | ||
| end |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
感觉直接用httplib的更直接，reader里面也封装了一下
Sorry, something went wrong.
pengsven
force-pushed
the
test.shuwen
branch
from
84058b2 to
10966ae
Compare
November 23, 2017 11:25
pengsven
force-pushed
the
test.shuwen
branch
from
10966ae to
62d8779
Compare
November 29, 2017 05:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.将一些writer、reader公用的http函数移动到httplib中
2.添加make_aws_put_s3_writer
3.添加make_quorum_http_writers