Add an "R only" layer for mixing R with other runtimes - #59
Open
kgutwin wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I'm not sure why this test is failing, I doubt it has anything to do with my changes. aws-lambda-r-runtime/tests/test_aws.py Line 29 in 6c8560a When I ran python3 -m unittest on my system, it failed here as well, although that was due to bad AWS credentials. When I fixed my AWS credentials, this test passed. Is this test dependent on AWS API access somehow? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My use case is primarily based on another language runtime (python) but would like to be able to also call R scripts. The build framework here only needs slight tweaks to deploy an "R only" layer that is suitable for combining with all other runtimes.
This PR currently only contains the changes to the build scripts to build and deploy the "R only" layer. Updates to the documentation and test framework can follow later if desired.
Also note that replacing the chown call with docker run --user $(id -u) should resolve issue #52.
Thanks!