Updated variable types, documentation and names - #45
MantautasRimkus wants to merge 2 commits into
Conversation
Sorry, something went wrong.
bangerth
left a comment
There was a problem hiding this comment.
Just a few comments.
Sorry, something went wrong.
| virtual | ||
| void | ||
| consume (InputType sample, | ||
| AuxiliaryData aux_data) override; |
There was a problem hiding this comment.
Can you run the indentation script? I think that is necessary for these lines.
Sorry, something went wrong.
| /** | ||
| * A function that returns the average cosine vector computed from the | ||
| * samples seen so far. If no samples have been processed so far, then | ||
| * a default-constructed object of value_type will be returned. |
There was a problem hiding this comment.
Write this as follows to make sure we get nice markup when doxygen converts the documentation to HTML:
| * a default-constructed object of value_type will be returned. | |
| * a default-constructed object of `value_type` will be returned. |
Sorry, something went wrong.
| * definition of "autocovariance" is more complex than what we do here (except | ||
| * if we work scalar samples types). That said, below we will use the word | ||
| * "autocovariance" even when refering to this spurious autocovariance. | ||
| * "autocovariance" even when refering to this spurious autocovariance. It can be looked as trace of |
There was a problem hiding this comment.
| * "autocovariance" even when refering to this spurious autocovariance. It can be looked as trace of | |
| * "autocovariance" even when refering to this spurious autocovariance. It can be looked as the trace of |
Sorry, something went wrong.
| * @f} | ||
| * In other words, it calculates the covariance of samples $x_{t+l}$ and $x_t$ | ||
| * with a lag between zero and $k$ | ||
| * with a lag l between zero and $k$ |
There was a problem hiding this comment.
| * with a lag l between zero and $k$ | |
| * with a lag $l$ between zero and $k$ |
Sorry, something went wrong.
| * \hat\gamma(l) | ||
| * = | ||
| * \frac{1}{n} \sum_{t=1}^{n-l}{(x_{t+l}-\bar{x})(x_{t}-\bar{x})}. | ||
| * \frac{1}{n-l} \sum_{t=1}^{n-l}{(x_{t+l}-\bar{x})(x_{t}-\bar{x})}. |
There was a problem hiding this comment.
OK :-)
Sorry, something went wrong.
|
Any news? |
Sorry, something went wrong.
As discussed on Friday, I have updated code for average cosinus. Also, I have fixed mistakes at the documentation of spurious autoregression and changed the variable name from "current_autocovariation" to "current_spur_autocovariance". All tests passed successfully.