FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Docs/b20 reference by soheimam · Pull Request #1775 · base/docs · GitHub

/ docs Public

Docs/b20 reference - #1775

Merged
soheimam merged 5 commits into
masterfrom
docs/b20-reference
Aug 12, 2026
ConversationCommits (5)ChecksFiles changed
Merged

Docs/b20 reference#1775
soheimam merged 5 commits into
masterfrom
docs/b20-reference

Conversation

soheimam commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What changed? Why?

Added b20 reference using b20 spec

mintlify Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
base 🟢 Ready View Preview Aug 5, 2026, 7:22 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

cb-heimdall commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1 Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

soheimam force-pushed the docs/b20-reference branch from c095dfd to 5bf2799 Compare August 5, 2026 20:42
roethke reviewed Aug 6, 2026
View reviewed changes

roethke left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The following mirror comments left on #1766.

  • Systematic selector/topic bug: enum params are hashed by type name instead of uint8, so every enum-bearing selector/topic is wrong.
  • SEIZE_RECEIVER_POLICY missing: the standard has 6 policy scopes; the reference shows 5, which also makes seizeWithMemo wrong (it gates the recipient).
  • Plus seizeWithMemo return type, finalizeUpdateAdmin access-control, ChildPoliciesOutsideOfRange signature, the burnBlocked "no longer part of this interface" claim, and missing MIN/MAX_COMPOSITE_CHILD_POLICIES + UIMultiplierUpdated.

Comment thread ...-chain/specs/upgrades/beryl/b20/specification/reference/interfaces/IB20Factory/createB20.mdx Outdated
Comment thread docs/base-chain/specs/upgrades/beryl/b20/specification/reference/interfaces/IB20Factory.mdx Outdated
Comment thread ...specs/upgrades/beryl/b20/specification/reference/interfaces/IPolicyRegistry/createPolicy.mdx Outdated
Comment thread ...ase-chain/specs/upgrades/beryl/b20/specification/reference/interfaces/IB20/seizeWithMemo.mdx Outdated
Comment thread ...pgrades/beryl/b20/specification/reference/interfaces/IPolicyRegistry/finalizeUpdateAdmin.mdx Outdated
Comment thread docs/base-chain/specs/upgrades/beryl/b20/specification/reference/interfaces/IB20.mdx Outdated
Comment thread docs/base-chain/specs/upgrades/beryl/b20/specification/reference/interfaces/IPolicyRegistry.mdx
Comment thread docs/base-chain/specs/upgrades/beryl/b20/specification/reference/errors-and-events-index.mdx Outdated
Comment thread docs/base-chain/specs/upgrades/beryl/b20/specification/reference/constants-and-addresses.mdx
Comment thread docs/base-chain/specs/upgrades/beryl/b20/specification/index.mdx
roethke reviewed Aug 10, 2026
View reviewed changes

roethke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Review — verified against current base/base-std (main) (selectors/topic0s checked with cast)

Overall the reference is faithful and high quality — precompile addresses, roles, policy scopes, constants, IPolicyRegistry, IActivationRegistry, IB20Factory, the full IB20 core, and the SEIZE model (SEIZE_ROLE / SEIZE_HOLDER_POLICY / SEIZE_RECEIVER_POLICY / seizeWithMemo) all match exactly. There's one clustered blocker: the IB20Asset scheduled-multiplier API is documented under pre-rename names, so the names and their selectors/topic0s are wrong.

🔴 Blocker — UIMultiplier* rename (source: src/interfaces/IB20Asset.sol on main)

  • IB20Asset/setUIMultiplier.mdx → updateUIMultiplier(uint256 newMultiplier, uint256 effectiveAt) (selector 0x628e600f)
  • IB20Asset/cancelScheduledMultiplier.mdx → cancelUIMultiplierUpdate() (0x2c97a0f0)
  • errors-and-events-index.mdx:
    • ScheduleOverlap → UIMultiplierUpdateExists(uint256 effectiveAt) (0x4481a68e)
    • NoScheduledMultiplier → UIMultiplierUpdateDoesNotExist() (0xa7d6a5ca)
    • MultiplierUpdateCancelled → UIMultiplierUpdateCancelled(uint256 cancelledMultiplier, uint256 cancelledEffectiveAt) (topic0 0x88385633…)
    • Add the deprecated event MultiplierUpdated(uint256 multiplier) (topic0 0x4dbe4840…), emitted by the instant updateMultiplier alongside UIMultiplierUpdated.
  • The old names also appear in IB20Asset.mdx, IB20Asset/OPERATOR_ROLE.mdx, and IB20Asset/updateMultiplier.mdx ("Prefer setUIMultiplier").

If these pages are generated, regenerating from current main is the cleanest fix.

Nits

  • scaledBalanceOf.mdx / IB20Asset.mdx: description says toScaledBalance(balanceOf(account)); source says toUIAmount(balanceOf(account)).
  • Missing pages: MAX_UI_MULTIPLIER() and the inherited ERC-8056 members (uiMultiplier, newUIMultiplier, effectiveAt, balanceOfUI, totalSupplyUI, toUIAmount/fromUIAmount) — at least uiMultiplier and MAX_UI_MULTIPLIER are worth adding.
  • updateMultiplier.mdx should note it emits both MultiplierUpdated (deprecated) and UIMultiplierUpdated.

Everything outside this cluster checks out.

roethke mentioned this pull request Aug 10, 2026
Open
roethke self-requested a review August 11, 2026 19:05
soheimam merged commit b74ed78 into master Aug 12, 2026
8 checks passed
soheimam deleted the docs/b20-reference branch August 12, 2026 17:05
youssefea added a commit that referenced this pull request Aug 20, 2026
Merge origin/master into docs/ia-overhaul-v2 (integration base)
dda6fb9 
Adopt Mind's v2 IA branch as base and merge current master so no live
content regresses. Conflict resolutions:

- Kept V2's new IA: docs.json nav, base-chain/overview (Integrate Base
  landing), beryl/cobalt overviews, b20-token-standard (concept+launch),
  cobalt/eip-8130.
- Took master's reviewed operational fixes: node-operators/snapshots
  (reth V2 migration #1808, full-vs-minimal #1754).
- Brought in master's B20 reference tree (112 files, #1775/#1812/#1829)
  and both native-account-abstraction pages.
- Accepted deletions: apps/** (migrated to build-on-base; content
  preserved), base-account/guides/accept-recurring-payments,
  specs/upgrades/beryl/b20 (superseded; WS-B redirects it).
- Dropped committed build artifacts (.astro/, .mintlify/) and gitignored
  them.
- Generated indexes (AGENTS.md, llms.txt, llms-full.txt) left at V2;
  regenerated at end of pipeline.

Reconciliation of overlapping B20 specs, NAA dedupe, and adding master's
reference tree to nav is handled in follow-up workstreams.

Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

roethke roethke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL