docs: Fix toolchain implementation file name - #2512
Merged
rickeylev merged 1 commit intoDec 18, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
It's pedantic, but it made me go back and double-check when reading the custom toolchain example, so I think it's worth preventing this confusion.
Copy link
Copy Markdown
Collaborator
|
Thanks! Nope, not pedantic at all -- it's confusing if the file names aren't consistent. re: visual bars: I'd be +1 on that. There's a lot of content in the example, so easy to get lost in what file something is for. |
Sorry, something went wrong.
rickeylev
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code example comment uses toolchain_impls (extra s), while the target references
use toolchain_impl (no s). This made me go back and double-check when reading the
custom toolchain example (especially the definitions in L425ff).
Remove the extra "s" in the comment so it matches what the target references are.