FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: generate publish wheels for target platforms by tomatotomata · Pull Request #4007 · bazel-contrib/rules_python · GitHub

fix: generate publish wheels for target platforms - #4007

Merged
aignas merged 9 commits into
bazel-contrib:mainfrom
tomatotomata:codex/publish-target-platforms
Aug 29, 2026
Merged

fix: generate publish wheels for target platforms#4007
aignas merged 9 commits into
bazel-contrib:mainfrom
tomatotomata:codex/publish-target-platforms

Conversation

tomatotomata commented Aug 5, 2026
edited by aignas
Loading

Copy link
Copy Markdown
Contributor

Summary:

  • Configure publish deps for a static list of platforms instead of host platform.
  • Add changelog and update lockfile.

This solves two issues:

  • The lock file could be different on different platforms.
  • The publish deps behave not as expected in RBE scenarios.

Fixes #3911

Comment thread MODULE.bazel Outdated

aignas commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

/backport

aignas commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

This would actually fix the MODULE.bazel.lock file non-reproducibility for users who are trying to use twine targets that rules_python defines.

github-actions Bot mentioned this pull request Aug 29, 2026
5 tasks
aignas enabled auto-merge August 29, 2026 04:57
aignas added this pull request to the merge queue Aug 29, 2026
Merged via the queue into bazel-contrib:main with commit 8d376b3 Aug 29, 2026
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pip.parse for rules_python_publish_deps doesn't set target_platforms, so twine only resolves for the platform that evaluated the module extension

2 participants


Back | FazBrowse Home | New Git URL