Fixing brittle Host Ruby version detection. - #56
Merged
kigster merged 1 commit intoDec 31, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ClareCat
reviewed
Dec 30, 2019
Comment thread
ruby/private/toolchains/ruby_runtime.bzl
Outdated
Instead of using ruby --version we should let ruby print it's own version, which is just a string, eg "2.6.5" so no fancy substring logic is required.
kigster
force-pushed
the
kig/fix-ruby-version-detection
branch
from
bd63f68 to
a273a8d
Compare
December 31, 2019 02:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using ruby --version we should let ruby print it's own version, which is just a string, eg "2.6.5" so no fancy substring logic is required.
This came up because I already had 2.6.5 installed, but it wasn't being detected for some reason.
Now it does.