FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Version vandidate 0.4.0 — upgrade Rubies + Setup by kigster · Pull Request #77 · bazelruby/rules_ruby · GitHub

/ rules_ruby Public

Version vandidate 0.4.0 — upgrade Rubies + Setup - #77

Merged
kigster merged 8 commits into
developfrom
kig/v0.4.0-candidate
Aug 4, 2020
ConversationCommits (8)ChecksFiles changed
Merged

Version vandidate 0.4.0 — upgrade Rubies + Setup#77
kigster merged 8 commits into
developfrom
kig/v0.4.0-candidate

Conversation

kigster commented Jul 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Upgraded the default Ruby version to 2.7.1
  • Adding a bin/clean script
  • Fixing a bunch of setup errors
  • Upgrading Bazel version, and OS-X brew-based setup
  • Upgrading rbenv/ruby-build and adding a proper rbenv installation if not there already
  • Adding more Ruby versions to the list of accepted local versions
  • Fixing a bug in a bin/linter

kigster requested a review from yugui as a code owner July 29, 2020 22:14
kigster self-assigned this Jul 29, 2020
kigster force-pushed the kig/v0.4.0-candidate branch 4 times, most recently from 4837537 to 22807b7 Compare August 4, 2020 21:44
kigster force-pushed the kig/v0.4.0-candidate branch from 22807b7 to baec9c7 Compare August 4, 2020 21:49
kigster force-pushed the kig/v0.4.0-candidate branch from 6650356 to 4c165b5 Compare August 4, 2020 22:05
kigster commented Aug 4, 2020
View reviewed changes

kigster left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This PR mostly upgrades dependencies and improves on the scripts that build and test.

kigster merged commit c449402 into develop Aug 4, 2020
kigster deleted the kig/v0.4.0-candidate branch August 4, 2020 22:55
lalten reviewed Nov 4, 2020
View reviewed changes
Comment thread ruby/private/sdk.bzl
Comment on lines +16 to +17
"2.7.1",
"2.7.1",

lalten Nov 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

was this intentional? Guessing this should be "2.7.0", "2.7.1",?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yugui Awaiting requested review from yugui yugui is a code owner
1 more reviewer
lalten lalten left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

kigster

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL