Repository navigation
look up indirect CRL entries by issuer and serial number - #2464
Closed
rootvector2 wants to merge 1 commit into
Closed
rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
pkix/src/test/java/org/bouncycastle/cert/test/IndirectCRLSerialCollisionTest.java
Dismissed
Copy link
Copy Markdown
Contributor
|
Thanks for the PR. Merged with minor revisions. Now up on https://www.bouncycastle.org/betas |
Sorry, something went wrong.
hubot
pushed a commit
that referenced
this pull request
Oct 5, 2026
…n indirect CRL by issuer as well as serial number, and look beyond the JDK's own serial number lookup, which sees only the CRL issuer's entries; CRL.isRevoked() no longer stops at another issuer's entry for the same serial number, and the jdk1.4 validators read an entry's certificate issuer through the class the provider's CRLs actually use, relates to github #2464.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCertStatus in the three cert path validator copies found a certificate's entry in an indirect CRL with getRevokedCertificate(serial) and compared only the issuer of whichever entry came first, so when another issuer's entry with the same serial number preceded the certificate's own (a serial number is only unique within its issuer, and aggregating issuers is what an indirect CRL is for) the revoked certificate validated; found reading the RFC 5280 sec. 5.3.3 handling in the validators, the lookup now checks every entry carrying the serial number against the issuer it applies to, X509CRLImpl implements the JDK's getRevokedCertificate(X509Certificate) the same way instead of inheriting the single-issuer default, and X509CRLEntryObject.equals keeps two identically encoded entries under different issuers apart so getRevokedCertificates() no longer drops one, with IndirectCRLSerialCollisionTest covering the provider validator, X509RevocationChecker and the direct lookup, failing without the change.
AI tooling was used to help prepare this change.