FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

#2476 Salsa20Engine.processBytes now XORs whole 64-byte keystream blo… by winne42 · Pull Request #2478 · bcgit/bc-java · GitHub

Repository navigation

#2476 Salsa20Engine.processBytes now XORs whole 64-byte keystream blo… - #2478

Closed
winne42 wants to merge 1 commit into
bcgit:mainfrom
winne42:#2476-chacha-scalar-win
Closed

winne42 wants to merge 1 commit into
bcgit:mainfrom
winne42:#2476-chacha-scalar-win

Conversation

winne42 commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

…cks in a plain loop instead of stepping a keystream index per byte, so Salsa20, XSalsa20, ChaCha and XChaCha20 run 1.3 to 1.75 times as fast

See #2476 for detailed explanation and benchmarks.

AI Disclosure

Parts of this contribution were produced with the assistance of a generative AI tool (Claude Code),
under the direction and review of the submitter, in line with the contributing guidelines. The submitter
has reviewed and understands the code. To the best of his knowledge, the contribution does not reproduce third-party material.

…m blocks in a plain loop instead of stepping a keystream index per byte, so Salsa20, XSalsa20, ChaCha and XChaCha20 run 1.3 to 1.75 times as fast

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dghgit self-assigned this Oct 2, 2026

dghgit commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

The patch looks good, but there doesn't appear to be an AI declaration on this - it's clearly done with AI assistance though. Please see CONTRIBUTING.md

winne42 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@dghgit sorry about that, AI disclosure note added to both ticket and PR (should it be only on one and not the other?). I found this wording of disclosure in another PR, hope this format is OK.
Maybe you could offer an issue template (and a PR template?) that already includes a formulation that you can accept?

dghgit commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR! Merged with minor revisions and now up on https://www.bouncycastle.org/betas

dghgit closed this Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL