FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add rake-compiler-dock for building Windows binary gems. by larskanis · Pull Request #117 · bcrypt-ruby/bcrypt-ruby · GitHub

Repository navigation

Add rake-compiler-dock for building Windows binary gems. - #117

Closed
larskanis wants to merge 2 commits into
bcrypt-ruby:masterfrom
larskanis:rake-compiler-dock
Closed

larskanis wants to merge 2 commits into
bcrypt-ruby:masterfrom
larskanis:rake-compiler-dock

Conversation

Copy link
Copy Markdown

rake-compiler-dock makes building Windows gems faster and with little to no setup compared to rake-compiler-dev-box. A simple 'rake gem:windows' is usually enough.

I tested building the fat binary bcrypt gems successfully on Linux and Windows. I also tested all resulting gems on RubyInstaller versions 2.1.4-x64, 2.2.1-x86 and 2.2.1-x64 on Windows-7.

The cross ruby versions used by gem:windows are not passed to the container, so the rake-compiler-dock's defaults are used, which are defined here.

This fixes #116 .

tenderlove closed this Oct 27, 2015
tenderlove reopened this Oct 27, 2015

Copy link
Copy Markdown
Collaborator

(Bumping for CI, sorry about the noise)

Copy link
Copy Markdown

Hi.
What is holding this merge? #128 states several cases where a genuine install fails on windows.

Copy link
Copy Markdown
Author

For what it's worth, I've updated this PR to rake-compiler-dock-0.5.1, which adds Ruby-2.3 support and fixes bundler compatiblity.

Copy link
Copy Markdown
Collaborator

We're not shipping binaries anymore! See #174

tjschuck closed this Nov 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for ruby 2.2.1 on Windows

4 participants


Back | FazBrowse Home | New Git URL