Repository navigation
Truncate secrets greater than 72 chars in hash_secret - #255
Merged
tenderlove merged 6 commits intoNov 30, 2021
Merged
tenderlove merged 6 commits into
tenderlove merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tjschuck
requested changes
Jul 7, 2021
tjschuck
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks for this PR! One technical issue, though: bcrypt truncates secrets at 72 bytes, not characters, so this probably isn't correct outside of the 1-byte character space.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Great catch! Updated to truncate based on bytesize instead and added a test for that. |
Sorry, something went wrong.
tjschuck
requested changes
Jul 8, 2021
Comment thread
spec/bcrypt/password_spec.rb
Outdated
Copy link
Copy Markdown
Contributor
Author
|
friendly ping |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225