Repository navigation
Add additional tests from OpenWall implementation sources - #84
Oscil8 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
* Fixes bcrypt-ruby#39, bcrypt-ruby#80 * Include new tests from upstream (fixes bcrypt-ruby#84)
* Fixes bcrypt-ruby#39, bcrypt-ruby#80 * Include new tests from upstream (fixes bcrypt-ruby#84)
* Fixes bcrypt-ruby#39, bcrypt-ruby#80 * Include new tests from upstream (fixes bcrypt-ruby#84)
|
status? can be closed? |
Sorry, something went wrong.
|
It's not merged, so no. Though, I did include the changes in #91. |
Sorry, something went wrong.
|
Yeah, the tests still show a probable issue; although the issue is likely in jBCrypt. I may have time next month to do some more debugging to try to identify the issue. |
Sorry, something went wrong.
|
Great! |
Sorry, something went wrong.
|
The jBCrypt issues appear to be due to character encoding due to use of Java's String.getBytes on input. Suggestion would be to pass byte[] array directly -- see POC at https://github.com/Oscil8/bcrypt-ruby/tree/wip/jruby-fix which does pass tests in either jruby or MRI. |
Sorry, something went wrong.
See http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/john/john/src/BF_fmt.c Note that these tests pass on MRI 1.8/1.9 but fail on jruby, the bugs are due to character encoding on input to the jBCrypt implementation.
* Fixes bcrypt-ruby#39, bcrypt-ruby#80 * Include new tests from upstream (fixes bcrypt-ruby#84)
* Fixes bcrypt-ruby#39, bcrypt-ruby#80 * Include new tests from upstream (fixes bcrypt-ruby#84)
Sorry, something went wrong.
See http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/john/john/src/BF_fmt.c
Note that these tests pass on MRI 1.8/1.9 but fail on jruby, the
bugs are likely in the jBCrypt implementation.
This is related to #82.