feat: support custom strategies on a queue - #134
Merged
skeggse merged 1 commit intoNov 2, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Coverage remained the same at 100.0% when pulling 02780d3 on calebboyd:own-strategies into bb31bca on bee-queue:master. |
Sorry, something went wrong.
calebboyd
force-pushed
the
own-strategies
branch
2 times, most recently
from
640d475 to
49e5c5c
Compare
July 16, 2018 19:17
skeggse
reviewed
Apr 9, 2020
skeggse
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Concept seems good to me - apologies for never seeing/reviewing this. Mostly just wondering about the failure case.
Sorry, something went wrong.
Comment thread
README.md
Outdated
Comment thread
index.d.ts
Outdated
Comment thread
test/queue-test.js
Outdated
Comment thread
lib/queue.js
Outdated
skeggse
approved these changes
Oct 28, 2020
skeggse
force-pushed
the
own-strategies
branch
2 times, most recently
from
dd28082 to
95525f0
Compare
November 2, 2020 04:29
skeggse
force-pushed
the
own-strategies
branch
from
95525f0 to
a7ab32a
Compare
November 2, 2020 04:34
skeggse
force-pushed
the
own-strategies
branch
from
a7ab32a to
02780d3
Compare
November 2, 2020 04:40
beequeueci
pushed a commit
that referenced
this pull request
Nov 2, 2020
## [1.3.0](v1.2.3...v1.3.0) (2020-11-02) ### Features * implement Queue#saveAll feature ([#198](#198)) ([851f09d](851f09d)) * support custom strategies on a queue ([#134](#134)) ([926de9d](926de9d)) * **types:** add generics to type definitions ([a565d3d](a565d3d)) * **types:** add isRunning ([c488385](c488385)) * **types:** add ready handler ([32c4b1e](32c4b1e)) ### Bug Fixes * **backoff:** allow no delay arg when setting immediate strategy ([#154](#154)) ([6f1d62f](6f1d62f)) * **queue:** remove error event listener on close ([#231](#231)) ([36b4904](36b4904)) * **removeJob:** remove job from stored jobs ([#230](#230)) ([a8c9d87](a8c9d87)) * **types:** support progress events using arbitrary data ([#140](#140)) ([bc8aa52](bc8aa52)) * **types:** update createJob handler for consistency ([b71a993](b71a993)) * **types:** update redis option type ([#290](#290)) ([e80c51d](e80c51d)) * **types:** update type declaration ([#252](#252)) ([1dce7ca](1dce7ca)) * misc edge case fixes ([a2df983](a2df983)) * update typescript declarations and add documentation ([#187](#187)) ([cec1498](cec1498)), closes [#138](#138)
beequeueci
pushed a commit
that referenced
this pull request
Nov 3, 2020
## [1.3.0](v1.2.3...v1.3.0) (2020-11-03) ### Features * implement Queue#saveAll feature ([#198](#198)) ([851f09d](851f09d)) * support custom strategies on a queue ([#134](#134)) ([926de9d](926de9d)) * **types:** add generics to type definitions ([a565d3d](a565d3d)) * **types:** add isRunning ([c488385](c488385)) * **types:** add ready handler ([32c4b1e](32c4b1e)) ### Bug Fixes * **backoff:** allow no delay arg when setting immediate strategy ([#154](#154)) ([6f1d62f](6f1d62f)) * **queue:** remove error event listener on close ([#231](#231)) ([36b4904](36b4904)) * **removeJob:** remove job from stored jobs ([#230](#230)) ([a8c9d87](a8c9d87)) * **types:** support progress events using arbitrary data ([#140](#140)) ([bc8aa52](bc8aa52)) * **types:** update createJob handler for consistency ([b71a993](b71a993)) * **types:** update redis option type ([#290](#290)) ([e80c51d](e80c51d)) * **types:** update type declaration ([#252](#252)) ([1dce7ca](1dce7ca)) * misc edge case fixes ([a2df983](a2df983)) * update typescript declarations and add documentation ([#187](#187)) ([cec1498](cec1498)), closes [#138](#138)
Copy link
Copy Markdown
Collaborator
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sorry, something went wrong.
This was referenced Nov 3, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables providing a custom function to determine an appropriate delay.
Must be set on all queue instances.