Feat | Job | Store progress with the whole job data - #339
Merged
skeggse merged 1 commit intoApr 29, 2021
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Any update on this PR ? 😢 |
Sorry, something went wrong.
skeggse
approved these changes
Apr 29, 2021
beequeueci
pushed a commit
that referenced
this pull request
May 19, 2021
Copy link
Copy Markdown
Collaborator
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We have multiple API instances adding bee-queue jobs.
Our workers call Job#reportProgress for long term jobs.
Depending on the API intance handling the call, it might not have the progress update.
Solution
I added the progress to the stored job data, same place as the status.
It ensures that the progress is saved properly, and that it is not 0 on a consumer recovering the job from redis.
I hope that it's mergable for you, and if so, I would like to know when a release with this feature is possible, so I know if a fork is needed for my project.