allow manual redis connection - #708
Conversation
Sorry, something went wrong.
compwright
left a comment
There was a problem hiding this comment.
Thank you for this contribution! I think it would be a bit more user-friendly to call the new option autoConnect and default it to true. If you don't want auto connection then you would manually set the option to false and call queue.connect(). Would you make this change for me?
Sorry, something went wrong.
|
@billyen2012 also please note the failing CI checks. You need to edit the commit message for all commits on this branch to comply with this standard: https://github.com/conventional-changelog/commitlint/#what-is-commitlint |
Sorry, something went wrong.
Suggested change has been applied |
Sorry, something went wrong.
Opps, I was unaware that I suppose to use npm run ci for all the test. should be okay now I also notice that sometimes the test will failed because when all the test suite are executed together, it will just make redis dropping connection. Not sure if it was just the issue of my redis, but I will suggest the following change to make the test more stable. (this is not in this PR)
|
Sorry, something went wrong.
## [1.6.0](v1.5.0...v1.6.0) (2023-11-02) ### Features * **queue:** allow manual connection ([#708](#708)) ([425fb89](425fb89))
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sorry, something went wrong.
Hey, this is a super awesome queue library.
I'm working on a next.js project and found that whenever I try to build the project, the build process will failed because Queue is try to connect to the redis host for some reasons.
Not sure if it is because the logic of connection to redis host is in the constructor of the Queue, but be able manually connect to redis seems to solve the problem.
So here is the pull request basically allowing user to manual connect to redis by calling queue.connect() after Queue instance is created.