| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
This reverts commit e3c1d0e.
|
Bumping docformatter to v1.7.8 in .pre-commit-config.yaml should fix the builds for python-support-testbed and rubicon-objc. I guess dependabot will handle this in the next days? The failed toga Android build on Windows seems to be unrelated to pre-commit, so I don't see a connection to this PR. |
Sorry, something went wrong.
|
Thanks - as you've noted, I'm guessing this will pass CI once dependabot has run on the downstream repos. |
Sorry, something went wrong.
|
I just realized that Dependabot is not configured to update pre-commit hooks, so this won't resolve itself (pre-commit support in Dependabot is a pretty new feature). How would a good resolution look like? I could spend some time on this in the next days.
|
Sorry, something went wrong.
I missed that announcement in Dependabot - but we've already worked around this. We have an independent pre-commit update workflow that is (or should be) installed on every repository. It runs on Sunday for "core" repositories, and on the first Sunday of the month for every other repository.
This is what we should be aiming for. PyCon US sprints are coming up, and this sort of upgrade is good fodder for first time contributors. It's not super urgent that it be done, it's relatively easy to explain, and it's spread across a lot of repositories. |
Sorry, something went wrong.
Sorry, something went wrong.
|
CI now passes; but we can't merge until beeware/briefcase#2815 has been merged. That's the last active reference to docformatter that I can find that hasn't been updated. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR reverts #260, which pinned the pre-commit Python version to 3.13 until docformatter supports 3.14.
97ac9c5 removed docformatter from the pre-commit config, so that bandaid is not necessary anymore.
Also, docformatter v1.7.8 was just released, now supporting Python 3.14: PyCQA/docformatter#342.
PR Checklist:
Sorry, I don't know how to test or document this.