Compile script - #311
Merged
mikeller merged 1 commit intoFeb 14, 2020
Merged
Compile script#311mikeller merged 1 commit into
mikeller merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Adds a script that compiles all Betaflight lua files the first time bf.lua is executed. build.sh has been repurposed to create a file containing a table with the files to be compiled. The .lua files are tested for errors using luac -p. No .luac files are created.
mikeller
approved these changes
Feb 12, 2020
mikeller
reviewed
Feb 13, 2020
Comment thread
src/SCRIPTS/BF/COMPILE/compile.lua
| collectgarbage() | ||
| return 0 | ||
| end | ||
| local file = io.open("COMPILE/scripts_compiled.lua", 'w') |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I had been looking for a way to persist state in lua - this seems to be a good way to do so.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
👍 . The first iteration of this had compile.lua delete it's contents when finished. Quickly abandoned that idea lol.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a script that compiles all Betaflight lua files the first time bf.lua is executed.
build.sh has been repurposed to create a file containing a table with the files to be compiled. The .lua files are tested for errors using luac -p. No .luac files are created.
As discussed in #281 the main memory issue we have now is running out of memory when compiling the betaflight lua scripts on the TX. OpenTX uses a modified version of LUA 5.2.2 with lua tiny RAM applied. This means that precompiled scripts will not work unless they are created with a version of lua that has had the same mod applied.
I believe the problem with on device compilation is that we're trying to load too many files in one lua cycle(bf.lua). The solution is to use a compile script that loads and compiles one file each lua cycle.
compile.lua will only run the first time bf.luais executed. It loads and compiles all files listed in scripts.lua one by one and exits when done. The next time bf.lua is executed everything will be as normal. compile.lua will not run again unless scripts_compiled.lua is modified or overwritten(new bf lua version).
"Free mem" in OpenTX shows over 40KB after running this(used to be close to 0 or out of memory).