FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Rates type support by klutvott123 · Pull Request #365 · betaflight/betaflight-tx-lua-scripts · GitHub

/ betaflight-tx-lua-scripts Public

Rates type support - #365

Merged
mikeller merged 1 commit into
betaflight:masterfrom
klutvott123:rates-type-support
Oct 11, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Rates type support#365
mikeller merged 1 commit into
betaflight:masterfrom
klutvott123:rates-type-support

Conversation

klutvott123 commented Oct 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Adds support for changing rates type.

Works like in the configurator. Changes labels, scaling, min, max, and applies default values for the selected rates type.

For testing: betaflight-tx-lua-scripts_1.5.0.zip

klutvott123 added this to the 1.6 milestone Oct 7, 2020

asizon commented Oct 7, 2020

Copy link
Copy Markdown
Member

Wow! Awesome work @klutvott123 , thankyou!

klutvott123 commented Oct 7, 2020

Copy link
Copy Markdown
Member Author

@asizon Thanks! 😸

mikeller reviewed Oct 8, 2020
View reviewed changes
Comment thread src/SCRIPTS/BF/ui.lua Outdated
end
elseif pageState == pageStatus.editing then
if event == EVT_VIRTUAL_EXIT or event == EVT_VIRTUAL_ENTER then
pcall(Page.fields[currentField].postEdit, Page)

mikeller Oct 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why do we need the pcall() here?

klutvott123 Oct 8, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It just prevents the script from crashing if the field doesn't have postEdit.
Could have done this too

if Page.fields[currentField].postEdit then
    Page.fields[currentField].postEdit(Page)
end

mikeller Oct 11, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I actually think this is a better way, as it is more specific. Otherwise any error that snuck into a postEdit() function could go undetected for a long time, causing debug nightmares.

klutvott123 Oct 11, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good point! I'll change it

mikeller previously approved these changes Oct 8, 2020
View reviewed changes

mikeller commented Oct 8, 2020

Copy link
Copy Markdown
Member

Nicely done!

Rates type support
4974c94 
Adds support for changing rates type.

sonarqubecloud Bot commented Oct 11, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

mikeller merged commit 9e2d4b8 into betaflight:master Oct 11, 2020
klutvott123 deleted the rates-type-support branch October 24, 2021 19:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mikeller mikeller approved these changes

Assignees

No one assigned

Labels

RN: IMPROVEMENT

Projects

None yet

Milestone

1.6

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL