FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Rc update by klutvott123 · Pull Request #394 · betaflight/betaflight-tx-lua-scripts · GitHub

Rc update - #394

Merged
mikeller merged 2 commits into
betaflight:masterfrom
klutvott123:rc-update
Oct 31, 2021
Merged

mikeller merged 2 commits into
betaflight:masterfrom
klutvott123:rc-update

Conversation

Copy link
Copy Markdown
Member

Updates feedforward and rc smoothing settings for BF 4.3 according to betaflight/betaflight#10723 and betaflight/betaflight#10650



Comment thread src/SCRIPTS/BF/PAGES/rx.lua Outdated
fields[#fields + 1] = { t = "Cutoff", x = x + indent, y = inc.y(lineSpacing), sp = x + sp, min = 0, max = 255, vals = { 27 }, table = { [0] = "Auto" } }
fields[#fields + 1] = { t = "Type", x = x + indent, y = inc.y(lineSpacing), sp = x + sp, min = 0, max = 3, vals = { 29 }, table = { [0] = "Off", "PT1", "BIQUAD", "Auto"} }
end
if apiVersion >= 1.040 then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can this block be moved to line 39?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure. Usually we're more worried about getting things in the "right" order and that sometimes means multiple checks for the same api version. In this case it's fine if we combine them. The order of things won't make any less sense than it currently does. lol

fields[#fields + 1] = { t = "Boost", x = x + indent, y = inc.y(lineSpacing), sp = x + sp, min = 0, max = 50, vals = { 53 } }
labels[#labels + 1] = { t = "Feedforward", x = x, y = inc.y(lineSpacing) }
fields[#fields + 1] = { t = "Transition", x = x + indent, y = inc.y(lineSpacing), sp = x + sp, min = 0, max = 100, vals = { 9 }, scale = 100 }
if apiVersion >= 1.044 then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lol, the conditional is not needed anymore.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes it is. We want to show these parameters for api version 1.044 and up.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops color blindness, reading too long I guess 🤦‍♂️

mikeller merged commit 2102034 into betaflight:master Oct 31, 2021
klutvott123 deleted the rc-update branch November 26, 2021 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL