Disable reboot for dynamic idle change - #410
Merged
klutvott123 merged 1 commit intoDec 19, 2021
Merged
klutvott123 merged 1 commit into
klutvott123 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
klutvott123
force-pushed
the
disable-dynamic-idle-reboot
branch
from
703b3d6 to
e199bf8
Compare
December 16, 2021 13:07
haslinghuis
approved these changes
Dec 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we had to reboot for dynamic idle changes to take effect. We also had to reboot when disabling rpm filters by setting rpm harmonics to 0 because dynamic idle couldn't work without rpm filters enabled.
After betaflight/betaflight#11043 dynamic idle does not depend on rpm filters being enabled and the reboot isn't necessary anymore.