Add Profiles page. - #432
Merged
klutvott123 merged 1 commit intoFeb 4, 2022
Merged
klutvott123 merged 1 commit into
klutvott123 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
haslinghuis
reviewed
Feb 3, 2022
Comment thread
src/SCRIPTS/BF/pages.lua
| end | ||
|
|
||
| if apiVersion >= 1.016 then | ||
| PageFiles[#PageFiles + 1] = { title = "Profiles", script = "profiles.lua" } |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Move to line 12?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
By having it like this the pages can be shuffled around as we please. and if a page is to be removed we have to break it out anyway. I also like the readability of the current approach of having a if for each page.
Sorry, something went wrong.
haslinghuis
approved these changes
Feb 3, 2022
This was
linked to
issues
Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a page with pid and rate profile.
Because of how it's implemented in the firmware, both profiles can't be changed at the same time.
Fixes #430 #230 #47 #22