fix shebang in bin/build.sh - #438
Merged
haslinghuis merged 1 commit intoJun 2, 2022
Merged
haslinghuis merged 1 commit into
haslinghuis merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Using env is a more portable approach.
Copy link
Copy Markdown
Member
|
Good find. But not sure if we need anything to fix. https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I found it by cloning the repo and trying to run make to test vs betaflight 4.3. My distro (NixOS) doesn't have /bin/bash (not even /usr/bin/bash) so we need to use env. The change is pretty harmless and should work everywhere. |
Sorry, something went wrong.
haslinghuis
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using env is a more portable approach.