FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Hide VTX menu when feature is unavailable by atomgomba · Pull Request #480 · betaflight/betaflight-tx-lua-scripts · GitHub

/ betaflight-tx-lua-scripts Public

Hide VTX menu when feature is unavailable - #480

Merged
haslinghuis merged 1 commit into
betaflight:masterfrom
atomgomba:hide-vtx-menu
Oct 19, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Hide VTX menu when feature is unavailable#480
haslinghuis merged 1 commit into
betaflight:masterfrom
atomgomba:hide-vtx-menu

Conversation

atomgomba commented May 25, 2023

Copy link
Copy Markdown
Contributor

This is one more step in handling the absence of VTX tables, completely hiding the option in the main menu would make scrolling a tiny bit more convenient and the user won't have to wait a few seconds for no reason just to see "N/A" when clicking on VTX menu.

Also I'm not sure if this is a good solution, I was thinking about potentially being able to hide options for other features as well (e. g. some users might have no GPS or OSD and we could hide those too, or whatever optional feature may come up in the future). Hiding the VTX menu alone would require a simpler logic, hence less new lines added.

github-actions Bot commented Jun 25, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions Bot commented Jul 3, 2023

Copy link
Copy Markdown

Pull request closed automatically as inactive.

github-actions Bot closed this Jul 3, 2023
haslinghuis reopened this Jul 3, 2023

github-actions Bot commented Jul 11, 2023

Copy link
Copy Markdown

Pull request closed automatically as inactive.

github-actions Bot closed this Jul 11, 2023
haslinghuis reopened this Jul 11, 2023

github-actions Bot commented Jul 19, 2023

Copy link
Copy Markdown

Pull request closed automatically as inactive.

github-actions Bot closed this Jul 19, 2023

atomgomba commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

Pull request closed automatically as inactive.

Bad bot

haslinghuis reopened this Jul 19, 2023
github-actions Bot removed the Inactive label Jul 20, 2023
haslinghuis linked an issue Jul 24, 2023 that may be closed by this pull request
Make VTX Tables optional for digital video systems (no VTX option for firmware cloud build) #482
Closed

github-actions Bot commented Aug 20, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

atomgomba commented Aug 22, 2023

Copy link
Copy Markdown
Contributor Author

Please accept this during Hacktoberfest :P

haslinghuis commented Aug 22, 2023

Copy link
Copy Markdown
Member

Have to ask the organizer @asizon 😂

haslinghuis added this to the 1.8 milestone Aug 22, 2023

asizon commented Aug 22, 2023

Copy link
Copy Markdown
Member

Lol, we need the Lua master here @klutvott123

atomgomba commented Oct 18, 2023

Copy link
Copy Markdown
Contributor Author

just out of curiosity, why is this stalled? any objections? @klutvott123

haslinghuis merged commit 70f5e47 into betaflight:master Oct 19, 2023
atomgomba added a commit to atomgomba/betaflight-tx-lua-scripts that referenced this pull request Oct 20, 2023
Information about hiding the menu, followup to betaflight#480
64903c6
atomgomba mentioned this pull request Oct 20, 2023
Merged

TheIsotopes commented Jan 9, 2024

Copy link
Copy Markdown

@atomgomba It would be nice if they could implement this for the OSD and GPS page as well. 👍

atomgomba mentioned this pull request Jan 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

haslinghuis haslinghuis approved these changes

Assignees

atomgomba

Labels

RN: IMPROVEMENT

Projects

None yet

Milestone

1.8

Development

Successfully merging this pull request may close these issues.

Make VTX Tables optional for digital video systems (no VTX option for firmware cloud build)

4 participants

Back | FazBrowse Home | New Git URL