fix(BBButton): prevent size change on hover for tertiary variant when focused - #22
Merged
Arthurk12 merged 3 commits intoMay 12, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… focused Replace `border: none` with `border: 1px solid transparent` in default and hover states so the button keeps consistent dimensions regardless of focus/active state, avoiding layout shift when hovering an active tertiary button.
Use nullish coalescing to safely handle optional $size prop when indexing CSS_SIZE_PROPERTIES, preventing "undefined cannot be used as an index type" compile error.
Duplicate import of pallete.ts in TextInput component.
Arthurk12
added a commit
to guiiBecker/bbb-ui-components-react
that referenced
this pull request
Jul 20, 2026
fix(BBButton): prevent size change on hover for tertiary variant when focused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace border: none with border: 1px solid transparent in default and hover states so the button keeps consistent dimensions regardless of focus/active state, avoiding layout shift when hovering an active tertiary button.
Additionally:
Closes #21