feat(BBBModal): add testId and closeButtonDataTest props - #44
Merged
Arthurk12 merged 1 commit intoJun 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Adds `testId` (forwarded to the underlying ReactModal element) and
`closeButtonDataTest` props. When `testId` is set and `closeButtonDataTest`
is omitted, the close button receives `${testId}-close-button`
automatically.
Arthurk12
added a commit
to guiiBecker/bbb-ui-components-react
that referenced
this pull request
Jul 20, 2026
feat(BBBModal): add `testId` and `closeButtonDataTest` props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds testId (forwarded to the underlying ReactModal element) and closeButtonDataTest props. When testId is set and closeButtonDataTest is omitted, the close button receives ${testId}-close-button automatically.
Closes Issue(s)
Closes #43