Repository navigation
Bump version, update js-binarypack with remove unused check. - #95
dominicklim merged 1 commit into
Conversation
Sorry, something went wrong.
|
Just wanted to add a +1 to this pull request: as a new binaryjs user, I ran into this console error and was a little concerned. Would be good to banish it. |
Sorry, something went wrong.
|
@bryancatanzaro Thanks for the support. If you use the forked version before the pull request is approved please let me know, specially if you see any bugs. I am very interested in seeing this pull request merged and I would be glad to try to squash some bugs if they appear. |
Sorry, something went wrong.
|
@SoleilNoirMedia I'm testing your fork right now, and everything looks good - the only difference I notice is that the console error is gone. =) |
Sorry, something went wrong.
There was a problem hiding this comment.
This commit shouldn't be part of the PR I guess :)
Sorry, something went wrong.
There was a problem hiding this comment.
@bgruening I have fixed the issue, I removed the commit. I had previously added a new one to fix the issue but I ended up rebasing and removing the commit, i felt it was the best solution to keep history clean.
Sorry, something went wrong.
|
Beside @ericz and or @michelle who else can approve/merge a pull request? |
Sorry, something went wrong.
Bump version, update js-binarypack with remove unused check.
It should resolve issues related to the binary service check: console errors, lack of secure connection support, etc.
Since the manner js-binarypack is now built (i.e. their use of of Browserify) the build task for binaryjs had to be modified as well. I would propose use a similar build for Binaryjs (I would be willing to open a PR later on).