FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Develop外部联系人客户详情新增增加字段 by huangxm129 · Pull Request #1690 · binarywang/WxJava · GitHub

/ WxJava Public

Develop外部联系人客户详情新增增加字段 - #1690

Merged
binarywang merged 5 commits into
binarywang:developfrom
huangxm129:develop
Jul 31, 2020
ConversationCommits (5)ChecksFiles changed
Merged

Develop外部联系人客户详情新增增加字段#1690
binarywang merged 5 commits into
binarywang:developfrom
huangxm129:develop

Conversation

huangxm129 commented Jul 29, 2020

Copy link
Copy Markdown

增加字段：remark_corp_name，addWay，oper_userid

外部联系人客户详情新增增加字段
2b27c03 
增加字段：remark_corp_name，addWay，oper_userid

Signed-off-by: huangxiaoming <huangxm129@163.com>
修改测试类
755c743 
Signed-off-by: huangxiaoming <huangxm129@163.com>
binarywang reviewed Jul 29, 2020
View reviewed changes
Comment thread ...-java-cp/src/test/java/me/chanjar/weixin/cp/api/impl/WxCpExternalContactServiceImplTest.java Outdated
public void testGetExternalContact() throws WxErrorException {
String externalUserId = this.configStorage.getExternalUserId();
WxCpUserExternalContactInfo result = this.wxCpService.getExternalContactService().getExternalContact(externalUserId);
WxCpUserExternalContactInfo result = this.wxCpService.getExternalContactService().getContactDetail(externalUserId);

binarywang Jul 29, 2020

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

这个为啥要改呢

huangxm129 Jul 29, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

看到getExternalContact方法已被废弃了，换了个新的方法测试了下

binarywang Jul 30, 2020

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

那你不应该改这个方法吧，不是已经有了testGetContactDetail方法吗？

huangxm129 Jul 31, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

已改

binarywang reviewed Jul 30, 2020
View reviewed changes
Comment thread ...-java-cp/src/test/java/me/chanjar/weixin/cp/api/impl/WxCpExternalContactServiceImplTest.java Outdated
public void testGetExternalContact() throws WxErrorException {
String externalUserId = this.configStorage.getExternalUserId();
WxCpUserExternalContactInfo result = this.wxCpService.getExternalContactService().getExternalContact(externalUserId);
WxCpUserExternalContactInfo result = this.wxCpService.getExternalContactService().getContactDetail(externalUserId);

binarywang Jul 30, 2020

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

那你不应该改这个方法吧，不是已经有了testGetContactDetail方法吗？

Comment thread weixin-java-cp/src/main/java/me/chanjar/weixin/cp/bean/WxCpUserExternalContactInfo.java Outdated
private Tag[] tags;
@SerializedName("remark_corp_name")
private String remarkCorpName;
@SerializedName("addWay")

binarywang Jul 30, 2020

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

这个字段是正确的吗？怎么不是下划线分割风格的？

huangxm129 Jul 31, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

已改

客户标签组查询列表功能修改
33e584d 
Signed-off-by: huangxiaoming <huangxm129@163.com>
修改测试类
03b33a9 
Signed-off-by: huangxiaoming <huangxm129@163.com>
修改 add_way字段错误
a570172 
Signed-off-by: huangxiaoming <huangxm129@163.com>
binarywang merged commit a776e9c into binarywang:develop Jul 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

binarywang binarywang left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL