FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

【微信OCR】WxOcrIdCardResult 补全字段: addr、gender、nationality by luomin0601 · Pull Request #2745 · binarywang/WxJava · GitHub

/ WxJava Public

【微信OCR】WxOcrIdCardResult 补全字段: addr、gender、nationality - #2745

Merged
binarywang merged 1 commit into
binarywang:developfrom
luomin0601:develop-lm-20220713
Jul 21, 2022
ConversationCommits (1)ChecksFiles changed
Merged

【微信OCR】WxOcrIdCardResult 补全字段: addr、gender、nationality#2745
binarywang merged 1 commit into
binarywang:developfrom
luomin0601:develop-lm-20220713

Conversation

luomin0601 commented Jul 13, 2022

Copy link
Copy Markdown

WxOcrIdCardResult add field:

addr、gender、nationality

原测试用例:

cn.binarywang.wx.miniapp.api.impl.WxMaOcrServiceImplTest#testIdCard

sonatype-lift Bot reviewed Jul 13, 2022
View reviewed changes
Comment thread weixin-java-common/src/main/java/me/chanjar/weixin/common/bean/ocr/WxOcrIdCardResult.java
@SerializedName("id")
private String id;
@SerializedName("addr")
private String addr;

sonatype-lift Bot Jul 13, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

SameNameButDifferent: The name addr; refers to [java.lang.SuppressWarnings, java.lang.String] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

binarywang added this to the 4.3.8 milestone Jul 14, 2022
binarywang merged commit 6cbfe0a into binarywang:develop Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sonatype-lift[bot] sonatype-lift[bot] left review comments
+1 more reviewer
ourines ourines left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.3.8

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL