refactor(open,channel): 消除 redis 配置存储与媒体下载执行器中的重复代码 - #4084
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
refactor(open,channel): 消除 redis 配置存储与媒体下载执行器中的重复代码#4084devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
open: 三个 WxOpenInRedis*ConfigStorage 的 20 个方法逐字符相同，抽取 AbstractWxOpenInRedisOpsConfigStorage 统一实现，子类仅保留构造函数。 channel: 两个媒体下载执行器中的 uri 拼参与临时文件命名逻辑上移到 ChannelMediaDownloadRequestExecutor。 Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
本 PR 延续 #4082 的思路，在 weixin-java-open 与 weixin-java-channel 模块内抽取公共父类/公共方法，以消除 CPD 扫描出的逐字符重复代码，目标是不改变既有对外行为。
Changes:
- open：抽取基于 WxRedisOps 的公共实现 AbstractWxOpenInRedisOpsConfigStorage，将 3 个 redis 配置存储实现类收敛为仅保留构造函数。
- channel：将媒体下载执行器中与具体 HTTP 客户端无关的 URI 参数拼接与临时文件落盘逻辑上移到 ChannelMediaDownloadRequestExecutor。
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| weixin-java-open/src/main/java/me/chanjar/weixin/open/api/impl/AbstractWxOpenInRedisOpsConfigStorage.java | 新增基于 WxRedisOps 的公共 redis 配置存储实现，集中承载原 3 份重复方法逻辑 |
| weixin-java-open/src/main/java/me/chanjar/weixin/open/api/impl/WxOpenInRedisConfigStorage.java | 改为继承新的公共父类，类内仅保留构造函数并透传 WxRedisOps/keyPrefix |
| weixin-java-open/src/main/java/me/chanjar/weixin/open/api/impl/WxOpenInRedisTemplateConfigStorage.java | 同上（RedisTemplate 适配实现） |
| weixin-java-open/src/main/java/me/chanjar/weixin/open/api/impl/WxOpenInRedissonConfigStorage.java | 同上（Redisson 适配实现） |
| weixin-java-channel/src/main/java/me/chanjar/weixin/channel/executor/ChannelMediaDownloadRequestExecutor.java | 新增 appendDataToUri / saveTmpFile 公共逻辑，供不同 HttpClient 实现复用 |
| weixin-java-channel/src/main/java/me/chanjar/weixin/channel/executor/ApacheHttpChannelMediaDownloadRequestExecutor.java | 使用父类公共逻辑替换重复代码 |
| weixin-java-channel/src/main/java/me/chanjar/weixin/channel/executor/HttpComponentsChannelMediaDownloadRequestExecutor.java | 使用父类公共逻辑替换重复代码 |
Sorry, something went wrong.
Comment thread
...pen/src/main/java/me/chanjar/weixin/open/api/impl/AbstractWxOpenInRedisOpsConfigStorage.java
| * | ||
| * @author yangyidian | ||
| */ | ||
| public abstract class AbstractWxOpenInRedisOpsConfigStorage extends AbstractWxOpenInRedisConfigStorage { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
续 #4082，继续清理 CPD 扫描出的模块内重复（均不改变对外 API 与行为）。
weixin-java-open：WxOpenInRedisConfigStorage、WxOpenInRedisTemplateConfigStorage、WxOpenInRedissonConfigStorage 三个类各 140 行，除构造函数外的 20 个方法（component ticket / access token、authorizer token、jsapi ticket、card api ticket、lock）逐字符相同，都只是在操作 WxRedisOps。抽取：
三个实现类只剩构造函数（super(redisOps, keyPrefix)），公共构造函数签名、可见性与 @NonNull 语义全部保留；原 private final WxRedisOps redisOps 字段本就不对外暴露。
weixin-java-channel：ApacheHttpChannelMediaDownloadRequestExecutor 与 HttpComponentsChannelMediaDownloadRequestExecutor 使用不同的 HttpClient 类型（httpclient4 / hc5），无法直接合并，但其中与 HTTP 库无关的两段逻辑重复，上移到公共父类 ChannelMediaDownloadRequestExecutor：
原代码中 if (StringUtils.isBlank(fileName) || baseName.length() < 3) 的前半段判断在该位置恒为 false（fileName 上一行已被兜底成时间戳），新实现改为等价且更直观的 StringUtils.isBlank(baseName) || baseName.length() < 3，结果一致。
验证
Link to Devin session: https://app.devin.ai/sessions/65a1cece5efb4304a7e6b85aaa562d7a
Requested by: @binarywang