FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upgrading to slf4j2 by josemduarte · Pull Request #1094 · biojava/biojava · GitHub

/ biojava Public

Upgrading to slf4j2 - #1094

Merged
josemduarte merged 3 commits into
biojava:masterfrom
josemduarte:slf4j2
May 22, 2024
ConversationCommits (3)ChecksFiles changed
Merged

Upgrading to slf4j2#1094
josemduarte merged 3 commits into
biojava:masterfrom
josemduarte:slf4j2

Conversation

josemduarte commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

As subject says

josemduarte requested a review from heuermh April 25, 2024 23:15
josemduarte requested a review from sbittrich May 22, 2024 05:04
sbittrich approved these changes May 22, 2024
View reviewed changes

sbittrich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks.

Because it's nearby in the code: Do we have a plan for the MMTF deprecation? The codec is still useful once mmtf.rcsb.org stops serving data but could also get rid of it.

josemduarte commented May 22, 2024

Copy link
Copy Markdown
Contributor Author

Because it's nearby in the code: Do we have a plan for the MMTF deprecation? The codec is still useful once mmtf.rcsb.org stops serving data but could also get rid of it.

Yes the codec is still useful, so in principle it is a good idea to keep for a while longer. I would not want it to stay too long though, because there's not much maintenance on the mmtf codec java libs.

josemduarte merged commit 50ac975 into biojava:master May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbittrich sbittrich approved these changes
heuermh Awaiting requested review from heuermh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL