FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ethereum Stop Sequence by MicahMaphet · Pull Request #4161 · bitpay/bitcore · GitHub

  1. bitpay
  2. bitcore

Repository navigation

Ethereum Stop Sequence - #4161

Open
MicahMaphet wants to merge 4 commits into
bitpay:masterfrom
MicahMaphet:eth-stop
ConversationCommits (4)ChecksFiles changed
Open

Ethereum Stop Sequence#4161
MicahMaphet wants to merge 4 commits into
bitpay:masterfrom
MicahMaphet:eth-stop

Conversation

MicahMaphet commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🛑 Description

Previously when using ethereum on bitcore-node, the server would never stop. This was caused by the ethereum rpcs not stopping. This solves this by tearing down rpcs after the worker stops all the services

🪵 Changelog

  • Tear down rpcs after the worker stops the services in all, api, and p2p

🧪 Testing Notes

Tested with a bitcore.config.json that only uses ethereum.
Run, and stop on master and eth-stop:

$ npm run p2p
[press ^C after ETH:regtest up to date message]
info :: 2026-05-08T06:27:30.011Z :: ETH:regtest up to date.
^Cinfo :: 2026-05-08T06:27:33.530Z :: Shutting down P2P pid 55016

Checklist

  • I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.

kajoseph reviewed Jun 10, 2026
View reviewed changes

kajoseph left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmm... So, this works. BUT, importing BaseEVMStateProvider in these files means that EVM indexes will be created in every instance of bitcore-node, regardless of the chains configured. Consequently, if someone's running an instance of bitcore-node only for UTXO chains, the indexes here will still be created since BaseEVMStateProvider imports packages/bitcore-node/src/providers/chain-state/evm/models/transaction.ts.

I suppose BaseEVMStateProvider needs a registry of services that needs to be tracked when teardownRpcs is called.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kajoseph kajoseph left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL