Fix setting fee asset by Asset - #124
Merged
xeroc merged 1 commit intoAug 6, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Not sure I understant that fix.
We should maybe add a check for elif isinstance(fee_asset, Asset):
fee_asset_id = fee_asset["id"]
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yeah you right, as fee_asset argument may be a different type, it needed to be handled properly. |
Sorry, something went wrong.
xeroc
added a commit
that referenced
this pull request
Aug 30, 2018
Release 0.1.20 ae7c969 (HEAD -> master) Merge branch 'release/0.1.20' bb5ba9d (release/0.1.20) version bump c8bac14 (origin/develop, develop) cleanup README 09d14a2 transactionbuilder make sure to add a recursive account as signed f75d23b sonarcloud setup 43b6f99 Update transaction builder and load exceptions properly 8bc7d1a export XML coverage 7f9750b add sonarcloud properties a5e38e2 add sonarcloud properties 879667f add sonarcloud to travis 27701d4 Ensure we do not have more keys for signing that are absolutely necessary 9eeb644 Merge pull request #124 from bitfag/fix-fee-asset 9328f84 Recognize Asset as argument for fee_asset cfb9000 consistently change to bitshare/ github organization 25cfa77 Fix comment 2af6d78 Merge pull request #117 from jhtitor/wipe_config 93001e9 parse daily pay as integer f7e9c68 Allow to set default instances in bitshares.py a7d867b Allow to load a simple object from blockchain easily a4bb897 Merge tag '0.1.19' into develop 9ebd2d5 Keep encrypted master password! ed83dba Add wipe method to Configuration storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codaone/DEXBot#263