Add non-lazy load for Witness and Worker lists. - #99
Merged
xeroc merged 2 commits intoJun 27, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## develop #99 +/- ##
==========================================
- Coverage 67.55% 59.6% -7.95%
==========================================
Files 56 37 -19
Lines 4475 3533 -942
==========================================
- Hits 3023 2106 -917
+ Misses 1452 1427 -25
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
In fact, the API call returns a list of the entire objects, so going "lazy" would be waste of transmitted data. Can we set the default behavior to lazy=False? |
Sorry, something went wrong.
xeroc
reviewed
May 28, 2018
Comment thread
bitshares/witness.py
| def __init__(self, only_active=False, **kwargs): | ||
| def __init__(self, only_active=False, lazy=True, **kwargs): | ||
| BlockchainInstance.__init__(self, **kwargs) | ||
| self.schedule = self.blockchain.rpc.get_object( |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is where an RPC call will happen no maater what lazy is
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
(Hopefully you meant both witness and worker lists, and not just witness list.) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you for your contribution! |
Sorry, something went wrong.
xeroc
added a commit
that referenced
this pull request
Jun 27, 2018
Release 0.1.17 1682c83 (HEAD -> master) Merge branch 'release/0.1.17' 045f38f (release/0.1.17) version bump 8706c06 (develop) fix expiration 8eec89e Merge branch 'cla-contributing' into develop de6dcb4 (origin/cla-contributing, cla-contributing) fixing markdown 0996b7e Updates to contribution and code of conduct 4d8db16 github presentation 74dfb05 initial CLA c4fdf86 (origin/develop) separate code of conduct and ocntributing 3d5dcff AUTHORS and CONTRIBUTING ec72929 Merge pull request #99 from jhtitor/witness_worker_lazy_list 6aa4448 Set default lazy to False when fetching Worker and Witness lists. efc63ba Order amount fix c602cad Allow to set and unset proxy for an account e9f4a26 Community link to telegram 677aefa Fix asset_fee declaration f5b8beb Fix unit test be51320 Merge remote-tracking branch 'origin/master' into develop 85cda76 Merge pull request #106 from jhtitor/acc_ext2 cd18153 Merge pull request #107 from jhtitor/test_message c218e59 Merge pull request #108 from jhtitor/pycryptodome 5a13484 Merge pull request #109 from tianyekuo/develop 3ff9e76 fix test f8e6f5f improve blockchainobject 7aa7d87 cache account name fa877c0 Test against witness node c50d500 cleanup setup.cfg 2a80da3 Remove limitation for maintenance collateral ratio 2bbcfc9 fix worker_create to require BTS - wouldn't work on testnet 6628144 updates to transactionbuilder dbae335 Finish migration to PyCryptodome. 5a6bea9 Set init0 as default account in message tests. c45981d Allow empty list as AccountCreateExtension(s) -- for real this time. 69dc9f3 fix #94 f0ca80d fix #86 1cea535 try to fix travis-ci 35ffe2b move configuration to setup.cfg and add flake8 strict pre-commit hook eea5132 fix tox.ini 4c16ed4 fix tox.ini 9c293c5 testing new tox.ini coverage settings 1065657 Fix #100 59c307d Add non-lazy load for Witness and Worker lists. bd96ce7 unit tests 26811ed Add required module 62bc46e Unified with pypeerplays and fix linting f27b3b5 Merge tag '0.1.16' into develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Little something I found useful.
(In my use case, I'm downloading/resolving stuff on a separate thread, no API calls should happen in the GUI thread. That's the reason you might see some PRs regarding lazy-load from me).