FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

added support for 'set' by FadyEssam · Pull Request #251 · boostorg/python · GitHub

/ python Public

added support for 'set' - #251

Open
FadyEssam wants to merge 2 commits into
boostorg:developfrom
FadyEssam:develop
ConversationCommits (2)ChecksFiles changed
Open

added support for 'set'#251
FadyEssam wants to merge 2 commits into
boostorg:developfrom
FadyEssam:develop

Conversation

FadyEssam commented Mar 3, 2019

Copy link
Copy Markdown

No description provided.

stefanseefeld reviewed Mar 3, 2019
View reviewed changes
Comment thread include/boost/python/set.hpp Outdated
#include <boost/python/ssize_t.hpp>

namespace boost {
namespace python {

stefanseefeld Mar 3, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please reformat the patch to use two spaces as indentation, rather than eight.

FadyEssam Mar 3, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think all the mentioned issues are resolved now

stefanseefeld commented Mar 3, 2019

Copy link
Copy Markdown
Member

Given the similarities with other Python types, perhaps you can guess what build logic needs to be added ? (Have a look at build/Jamfile).
Similarly, perhaps you could clone some of the logic from test/dict.* to come up with a test for set ?

stefanseefeld commented Mar 3, 2019

Copy link
Copy Markdown
Member

There are still a few pieces of build infrastructure missing:

FadyEssam commented Mar 3, 2019

Copy link
Copy Markdown
Author

done, Thanks for the guidance

lightmare reviewed Dec 5, 2019
View reviewed changes
Comment thread src/set.cpp
}
else
{
this->attr("discrad")(x);

lightmare Dec 5, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

there's a typo here

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

stefanseefeld stefanseefeld left review comments
+1 more reviewer
lightmare lightmare left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL