FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed calling_conventions tests on MinGW by Kojoley · Pull Request #257 · boostorg/python · GitHub

/ python Public

Fixed calling_conventions tests on MinGW - #257

Open
Kojoley wants to merge 1 commit into
boostorg:developfrom
Kojoley:fix-calling_conventions-tests-on-mingw
ConversationCommits (1)ChecksFiles changed
Open

Fixed calling_conventions tests on MinGW#257
Kojoley wants to merge 1 commit into
boostorg:developfrom
Kojoley:fix-calling_conventions-tests-on-mingw

Conversation

Kojoley commented Mar 27, 2019

Copy link
Copy Markdown
Contributor

On MinGW calling conversion are actually macros that are expanded into a GCC attribute (e.g. __fastcall expands into __attribute__((__fastcall__))).

Fixed calling_conventions tests on MinGW
ae05955 
On MinGW calling conversion are actually macros that are expanded into a GCC
attribute (e.g. `__fastcall` expands into `__attribute__((__fastcall__))`).

Kojoley commented Apr 2, 2019

Copy link
Copy Markdown
Contributor Author

Ping

stefanseefeld commented Apr 2, 2019

Copy link
Copy Markdown
Member

Sorry for my silence. Me not being a Windows developer I feel a bit uncomfortable reviewing this. Do you think it would be possible to add a MinGW (cross-)compiler to the mix of compilers we use on Travis-CI or AppVeyor ? That would help prove that things work as intended.

Kojoley commented Apr 2, 2019

Copy link
Copy Markdown
Contributor Author

I seen other boost projects use mingw on appveyor, I could have added it here, but I do know nothing about faber (and it seems to not run module tests #254).

stefanseefeld commented Apr 2, 2019

Copy link
Copy Markdown
Member

OK, fair point. I'll thus try to add MinGW to the mix, then we should be able to see whether this PR fixes one (or more) failures.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL