Replace Boost::foreach dependency with range-based for - #465
Open
georgthegreat wants to merge 2 commits into
Open
Replace Boost::foreach dependency with range-based for#465georgthegreat wants to merge 2 commits into
georgthegreat wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
These public dependencies require C++11:
It is perfectly reasonable to drop C++03 support in Boost::python, too. |
Sorry, something went wrong.
e-kwsm
reviewed
Jan 21, 2025
e-kwsm
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
python/.github/workflows/test-ubuntu.yml
Line 14 in 4fc3afa
drop c++98?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the library is still marked as c++03 compatible I wonder if the time has come to follow the rest of the boost libraries and raise it up to c++11.