FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add cygwin64 support to wrap_python.hpp by fatso83 · Pull Request #49 · boostorg/python · GitHub

Add cygwin64 support to wrap_python.hpp - #49

Merged
stefanseefeld merged 1 commit into
boostorg:developfrom
fatso83:develop
Mar 6, 2016
Merged

stefanseefeld merged 1 commit into
boostorg:developfrom
fatso83:develop

Conversation

fatso83 commented Dec 9, 2015

Copy link
Copy Markdown

This patch adds 64 bit support.

Currently the lack of 64 bit support for Cygwin prevents projects from compiling on Cygwin64 (see ycm-core/YouCompleteMe#684). Variations of this fix has been circulating for a few years.

Originally submitted on the old Trac issue tracker 9 months ago.

This patch adds 64 bit support.

c-nixon commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

@fatso83
Thanks for posting this across! And thanks for leaving my name on it, I was going to do it myself this evening, but you beat me to it.

Unfortunately I no longer have any windows machines available to me to help with any questions (not that I expect too many with such a small patch) so feel free to put your name on the commit if you're in a better position to shepherd it along.

Copy link
Copy Markdown

I can confirm that boost/python/detail/wrap_python.hpp still has to be patched to support Boost.Python on Cygwin64 (I'm using Boost 1.60.0).

An alternative patch is wrapping #define SIZEOF_LONG 4 with an #ifndef:

#ifndef SIZEOF_LONG
# define SIZEOF_LONG 4
#endif

This works as Cgwin64 defines SIZEOF_LONG in /usr/include/python2.7/pyconfig.h (which is included by boost/python/detail/wrap_python.hpp).

stefanseefeld added a commit that referenced this pull request Mar 6, 2016
Add cygwin64 support to wrap_python.hpp
stefanseefeld merged commit 5233f45 into boostorg:develop Mar 6, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL