FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Windows CI: Exit workflow on any errors; fix vcpkg caching by stephengtuggy · Pull Request #522 · boostorg/python · GitHub

Windows CI: Exit workflow on any errors; fix vcpkg caching - #522

Open
stephengtuggy wants to merge 8 commits into
boostorg:developfrom
stephengtuggy:exit-windows-ci-on-error
Open

Windows CI: Exit workflow on any errors; fix vcpkg caching#522
stephengtuggy wants to merge 8 commits into
boostorg:developfrom
stephengtuggy:exit-windows-ci-on-error

Conversation

stephengtuggy commented Jun 27, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #521 (hopefully).

Fixes #523 .

stephengtuggy changed the title Windows CI: Exit workflow on any errors during build or test phases Windows CI: Exit workflow on any errors Jun 27, 2026
stephengtuggy marked this pull request as ready for review June 27, 2026 16:57
stephengtuggy changed the title Windows CI: Exit workflow on any errors Windows CI: Exit workflow on any errors; fix vcpkg caching Jun 28, 2026

Copy link
Copy Markdown
Member

Can you explain the change ? It looks to me like you merely replaced cmd by pwsh and changed the commands accordingly. How does that affect the caching ?

Copy link
Copy Markdown
Contributor Author

Can you explain the change ? It looks to me like you merely replaced cmd by pwsh and changed the commands accordingly. How does that affect the caching ?

Yes, I can explain. The cache save step was failing with an error that the paths given did not exist -- even though they did. Removing the quotes from the paths fixed that. The cache save step is now succeeding, and at least some of the time, the cache restore step is now also succeeding, because there is a cache entry to retrieve.

I also fixed the cache key calculation, which was incorrect. I originally copy-pasted it from one of my other repositories, and it included some matrix parameters that are not valid in this repository. That is now fixed.

The other changes may or may not be relevant. As you said, I changed the shell used to PowerShell, and changed the commands accordingly. I have a little bit more confidence that PowerShell will actually fail the build if a test fails, vs. cmd.exe. But I'm not 100% sure that it really makes a difference.

Copy link
Copy Markdown
Member

OK, but the two shell changes (from cmd to pwsh in the build and test steps) are unrelated and not needed, yes ?

Copy link
Copy Markdown
Contributor Author

OK, but the two shell changes (from cmd to pwsh in the build and test steps) are unrelated and not needed, yes ?

From this SuperUser question and this StackOverflow one, it seems that switching to PowerShell is necessary in order to stop on any error, but by itself it's not sufficient. I will need to add some more logic.

Copy link
Copy Markdown
Contributor Author

OK, but the two shell changes (from cmd to pwsh in the build and test steps) are unrelated and not needed, yes ?

From this SuperUser question and this StackOverflow one, it seems that switching to PowerShell is necessary in order to stop on any error, but by itself it's not sufficient. I will need to add some more logic.

Done. @stefanseefeld please review

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows CI: vcpkg dependency caching not working Windows CI does not fail if one or more tests fail

2 participants


Back | FazBrowse Home | New Git URL