Add test for multi-threaded import of multi-phase module - #524
Draft
o01eg wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Also tests module state isolation
o01eg
marked this pull request as draft
July 2, 2026 08:53
Osyotr
reviewed
Aug 23, 2026
Comment thread
test/multi_thread_import_.cpp
Comment on lines
+156
to
+157
| // Boost.Python doesn't support Py_Finalize yet. | ||
| // Py_Finalize(); |
Copy link
Copy Markdown
There was a problem hiding this comment.
Is this actually true?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Same line is still in test/import_.cpp.
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
It was authored before git migration and that was in 2007...
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also tests module state isolation