bootc-ubuntu-setup: Add support for ubuntu-26.04 runners - #52
Open
cgwalters wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cgwalters
requested review from
gursewak1997
and
a balanced review from Copilot
August 19, 2026 18:44
Ubuntu 26.04 ships a sufficiently modern podman (with heredoc support and no manifest handling bugs), so unlike 24.04 we can skip the plucky PPA and package upgrade path entirely. This simplifies the setup on 26.04 to just installing `just`. The version gate is refactored from a hard `test` assertion into a `case` statement that dispatches per-version setup logic and rejects unsupported runners with a clear error. CI test jobs are added for ubuntu-26.04 in both PR and published-action workflows. The PR test includes a heredoc Containerfile build to verify the native podman meets the minimum capability bar per the acceptance criteria. Closes: #49 Assisted-by: Claude Code (Claude Opus 4) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
support-ubuntu-2604-signoff
branch
from
c6ae182 to
844445a
Compare
August 19, 2026 18:45
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Adds Ubuntu 26.04 support to the reusable setup action while retaining Ubuntu 24.04’s package-upgrade path.
Changes:
- Dispatches package setup by Ubuntu version.
- Adds Ubuntu 26.04 PR and published-action jobs.
- Verifies native Podman heredoc support in CI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bootc-ubuntu-setup/action.yml | Adds Ubuntu 26.04 package setup. |
| .github/workflows/test-actions-pr.yml | Tests setup and Podman heredocs on 26.04. |
| .github/workflows/test-actions-published.yml | Smoke-tests the published action on 26.04. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
The ubuntu-24.04 and ubuntu-26.04 bootc-ubuntu-setup test jobs in test-actions-pr.yml and test-actions-published.yml each check the same basic host functionality after setup runs: podman actually runs a container, and the runner's preinstalled (not the pinned setup-rust) Rust and Go toolchains still work. This duplicates the same checks across two jobs and two workflow files. Factor these into a composite action under .github/actions/ rather than the repo's top-level action directories, since this is an internal test helper rather than a published, supported action like bootc-ubuntu-setup or setup-rust. This commit only adds the action; it is not yet wired into any workflow. Assisted-by: AI
Both bootc-ubuntu-setup test jobs (ubuntu-24.04 and ubuntu-26.04) in test-actions-pr.yml, plus their equivalents in test-actions-published.yml, duplicated the same podman/Rust/Go sanity checks inline. Replace that duplication with the composite action added in the prior commit. The local-checkout workflow references the action by relative path (./.github/actions/verify-basic-requirements), while the published workflow references it remotely the same way it already does for bootc-ubuntu-setup and setup-rust (bootc-dev/actions/.github/actions/verify-basic-requirements@main), since GitHub Actions supports uses: for any subdirectory of a repo. The remaining 'Verify setup' step keeps just --version and test -n "$ARCH", which are outputs specific to bootc-ubuntu-setup rather than generic host checks, dropping only the now-redundant podman --version line. Assisted-by: AI
gursewak1997
approved these changes
Aug 19, 2026
gursewak1997
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Just needs signed off by: for 2 commits
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same content as #50, with a Signed-off-by added since I could not
push directly to the redhat-chai-bot fork branch (maintainer_can_modify
is false and I don't have collaborator access on that fork).
Closes #50
Assisted-by: Claude Code (Claude Opus 4)