composefs+UKI: Try to generate image with matching digest - #2353
Draft
cgwalters wants to merge 3 commits into
Draft
composefs+UKI: Try to generate image with matching digest #2353cgwalters wants to merge 3 commits into
cgwalters wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Signed-off-by: bootc-bot[bot] <225049296+bootc-bot[bot]@users.noreply.github.com> Signed-off-by: Colin Walters <walters@verbum.org>
The composefs-rs update added a required OciTransformOptions parameter to generate_boot_image, create_filesystem, and read_container_root. Pass Default::default() at all call sites to preserve the previous behavior (no xattr filtering). Assisted-by: AI Signed-off-by: John Eckersberg <jeckersb@redhat.com> Signed-off-by: Colin Walters <walters@verbum.org>
We had two changes in composefs-rs: - xattr filtering - v1 vs v2 EROFS When we switched to v1 for the EROFS generation by default, it broke UKI upgrades when the system was deployed with an older bootc. Unfortunately, there's no easy way to fix this (short of reverting the change to v1 by default). But at least with this approach, one can more easily temporarily use a newer bootc on the client, and it will be able to adapt to e.g. having an *older* bootc (perhaps using v2) in the target environment. Assisted-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had two changes in composefs-rs:
When we switched to v1 for the EROFS generation by default, it
broke UKI upgrades when the system was deployed with an older
bootc.
Unfortunately, there's no easy way to fix this (short of
reverting the change to v1 by default).
But at least with this approach, one can more easily temporarily
use a newer bootc on the client, and it will be able to adapt
to e.g. having an older bootc (perhaps using v2) in the target
environment.
Assisted-by: AI
Signed-off-by: Colin Walters walters@verbum.org