feat: support ioredis v6.0.0 - #23
Open
theoludwig wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
theoludwig
commented
Aug 17, 2026
Comment thread
package.json
| "c8": "^11.0.0", | ||
| "del-cli": "^7.0.0", | ||
| "hot-hook": "^1.0.0", | ||
| "ioredis": "^5.11.1", |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I don't know if you want your test suite to test both versions or not (I don't think it's worth it), but in a "ideal" world/test coverage scenario, if we want to support both versions, we might want to have e2e tests that cover both.
Sorry, something went wrong.
Comment thread
package.json
| "@opentelemetry/core": "^1.30.0 || ^2.0.0", | ||
| "@opentelemetry/instrumentation": "^0.200.0", | ||
| "ioredis": "^5.0.0", | ||
| "ioredis": "^5.0.0 || ^6.0.0", |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Should we support both or the breaking change is fine?
Suggested change
| "ioredis": "^5.0.0 || ^6.0.0", | |
| "ioredis": "^6.0.0", |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
https://github.com/redis/ioredis/releases/tag/v6.0.0
The main breaking changes are:
queue/package.json
Line 137 in 2ebc06e
This should not impact it either, and if a user ever hit a RESP3 difference, new Redis({ protocol: 2 }) restores the v5 wire protocol.