FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix DELETE key not being recognized by bkad · Pull Request #611 · bpython/bpython · GitHub

/ bpython Public

Fix DELETE key not being recognized - #611

Merged
thomasballinger merged 1 commit into
bpython:masterfrom
bkad:patch-1
Jun 6, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Fix DELETE key not being recognized#611
thomasballinger merged 1 commit into
bpython:masterfrom
bkad:patch-1

Conversation

bkad commented Apr 19, 2016

Copy link
Copy Markdown
Contributor

curtsies stopped supporting PADDELETE at this point: thomasballinger/curtsies@4150164
fixes #609

Fix DELETE key not being recognized
302bf49 
curtsies stopped supporting PADDELETE  at this point: thomasballinger/curtsies@4150164
fixes bpython#609

thomasballinger commented Apr 20, 2016

Copy link
Copy Markdown
Member

Thanks, lgtm.

Any thoughts on whether Curtsies should report this as delete or paddelete? The change brought Curtsieskey names in line with Blessed names which I trusted more than the names I had.

bkad commented Apr 20, 2016

Copy link
Copy Markdown
Contributor Author

I think DELETE is more clear and succinct than PADDELETE.

safiyat commented May 19, 2016

Copy link
Copy Markdown

@thomasballinger
DELETE works for me. PADDELETE didn't.

@bkad Thanks!

thomasballinger merged commit f21a68b into bpython:master Jun 6, 2016
bkad deleted the patch-1 branch June 6, 2016 02:14
thomasballinger mentioned this pull request Jun 6, 2016
Closed
sebastinas reviewed Jun 6, 2016
View reviewed changes
Comment thread bpython/curtsiesfrontend/manual_readline.py


@edit_keys.on('<PADDELETE>')
@edit_keys.on('<DELETE>')

sebastinas Jun 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should this handle both DELETE and PADDELETE?

RafaAguilar Sep 14, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

On Manjaro Linux (Arch) <PADDELETE> doesn't worked either.

Pypi's package doesn't have this change.

thomasballinger Sep 14, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@sebastinas Right now in curtsies there isn't a PADDELETE, but it wouldn't hurt to add it if paddelete should do this too.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DEL key not working on OS X (10.11.3) after the switch to curtsies 2.2

5 participants

Back | FazBrowse Home | New Git URL