FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed bug with sys.stdin.readline() by TheQu1etOwl · Pull Request #909 · bpython/bpython · GitHub

Fixed bug with sys.stdin.readline() - #909

Closed
TheQu1etOwl wants to merge 1 commit into
bpython:mainfrom
TheQu1etOwl:main
Closed

TheQu1etOwl wants to merge 1 commit into
bpython:mainfrom
TheQu1etOwl:main

Conversation

Copy link
Copy Markdown


I fixed this bug:

codecov-commenter commented Aug 22, 2021
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #909 (fadc1fb) into main (f7d8b77) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
- Coverage   67.93%   67.91%   -0.03%     
==========================================
  Files          61       61              
  Lines        9150     9153       +3     
==========================================
  Hits         6216     6216              
- Misses       2934     2937       +3     
Impacted Files Coverage Δ
bpython/curtsies.py 50.67% <0.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d8b77...fadc1fb. Read the comment docs.

Copy link
Copy Markdown
Contributor

I fear that this just hides an issue. self.current_stdouterr_line has the wrong time in this case and that should be fixed.

thomasballinger self-assigned this Oct 7, 2021
thomasballinger added a commit that referenced this pull request Oct 7, 2021
Static types would have helped! I'll add some.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL