FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Move WebGL Marks in a separate package by martinRenou · Pull Request #1389 · bqplot/bqplot · GitHub

/ bqplot Public

Move WebGL Marks in a separate package - #1389

Merged
martinRenou merged 1 commit into
bqplot:masterfrom
martinRenou:get_rid_webgl
Oct 21, 2021
Merged

Move WebGL Marks in a separate package#1389
martinRenou merged 1 commit into
bqplot:masterfrom
martinRenou:get_rid_webgl

Conversation

martinRenou commented Jul 19, 2021
edited
Loading

Copy link
Copy Markdown
Member

Move WebGL marks to the bqplot-gl package

martinRenou changed the title Get rid of WebGL related stuffs Get rid of WebGL related marks Jul 19, 2021
martinRenou force-pushed the get_rid_webgl branch 2 times, most recently from aec46ca to 607abb2 Compare July 20, 2021 13:48
martinRenou changed the title Get rid of WebGL related marks Move WebGL Marks in a separate package Jul 20, 2021
martinRenou force-pushed the get_rid_webgl branch 4 times, most recently from c0d34d1 to dacff09 Compare July 21, 2021 06:59
Comment thread bqplot/marks.py
martinRenou force-pushed the get_rid_webgl branch 2 times, most recently from c3c0d24 to a6a038a Compare August 30, 2021 07:32
martinRenou marked this pull request as ready for review August 30, 2021 14:36

martinRenou commented Aug 30, 2021
edited
Loading

Copy link
Copy Markdown
Member Author

PR tested with https://github.com/bqplot/bqplot-gl in bqplot/bqplot-gl#7 (adding visual tests with Galata and current JS tests soon)

Copy link
Copy Markdown
Member

What about creating a webgl canvas, and letting the marks create a threejs renderer if needed?

Copy link
Copy Markdown
Member Author

@maartenbreddels thanks for the review :)

What about creating a webgl canvas, and letting the marks create a threejs renderer if needed?

What would be the upside of this?

Copy link
Copy Markdown
Member

Most of the code in the Figure class can stay as it is (only the line/lines that creates the rendered will change), and we don't need any Figure subclass.

Copy link
Copy Markdown
Member Author

Right! Yeah that would be cool. I'll try it this way then.

maartenbreddels commented Sep 22, 2021
edited
Loading

Copy link
Copy Markdown
Member

This means you can write a threejs, raw WebGL, or Regl marks and mix them.

martinRenou force-pushed the get_rid_webgl branch 7 times, most recently from 728a8aa to f5a122a Compare October 4, 2021 14:17

Copy link
Copy Markdown
Member Author

@maartenbreddels the webgl context is now created here in bqplot and we don't need to subclass the Figure

Copy link
Copy Markdown
Member

Yes, very cool!
The only worry I have is that now we don't lazily create the context, like before using createWebGLRenderer (which now should be called createWebGLCanvas I think. Otherwise, we'll create these contexts too often, and the web-browser will show this 'broken' image because we created too many WebGL context.

martinRenou force-pushed the get_rid_webgl branch 3 times, most recently from 177a357 to 3b6e2a3 Compare October 21, 2021 09:06

Copy link
Copy Markdown
Member Author

The only worry I have is that now we don't lazily create the context, like before using createWebGLRenderer (which now should be called createWebGLCanvas I think. Otherwise, we'll create these contexts too often, and the web-browser will show this 'broken' image because we created too many WebGL context.

This should be resolved now :)

martinRenou merged commit dbc6398 into bqplot:master Oct 21, 2021
martinRenou deleted the get_rid_webgl branch October 21, 2021 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL