chore: fix deprecation warnings/issues and let pytest catch them - #1406
Merged
martinRenou merged 1 commit intoSep 30, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
maartenbreddels
force-pushed
the
chore_no_deprecation_warnings
branch
from
6a15a98 to
d62a9b3
Compare
September 28, 2021 14:55
martinRenou
force-pushed
the
chore_no_deprecation_warnings
branch
from
d62a9b3 to
ff4fb1c
Compare
September 30, 2021 15:23
Copy link
Copy Markdown
Member
|
Rebased, the CI should pass now |
Sorry, something went wrong.
meeseeksmachine
pushed a commit
to meeseeksmachine/bqplot
that referenced
this pull request
Sep 30, 2021
…et pytest catch them
martinRenou
added a commit
that referenced
this pull request
Sep 30, 2021
…6-on-0.12.x Backport PR #1406 on branch 0.12.x (chore: fix deprecation warnings/issues and let pytest catch them)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will clean up not only our test output, but also others, we only got one left from traittypes now:
$ py.test tests --pdb jdaviz-dev =============================== test session starts ================================ platform darwin -- Python 3.7.10, pytest-6.1.2, py-1.10.0, pluggy-0.13.1 rootdir: /Users/maartenbreddels/src/bqplot, configfile: pytest.ini plugins: asdf-2.8.0, anyio-3.0.1 collected 10 items tests/binary_serialization_test.py ..... [ 50%] tests/marks_test.py .... [ 90%] tests/selector_test.py . [100%] ================================= warnings summary ================================= ../../miniconda3/envs/jdaviz-dev/lib/python3.7/site-packages/traittypes/traittypes.py:24 /Users/maartenbreddels/miniconda3/envs/jdaviz-dev/lib/python3.7/site-packages/traittypes/traittypes.py:24: DeprecationWarning: Sentinel is not a public part of the traitlets API. It was published by mistake, and may be removed in the future. """) -- Docs: https://docs.pytest.org/en/stable/warnings.html ========================== 10 passed, 1 warning in 0.19s ===========================